resolve: Make sure visibilities of import declarations make sense#155213
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Apr 20, 2026
Merged
resolve: Make sure visibilities of import declarations make sense#155213rust-bors[bot] merged 2 commits intorust-lang:mainfrom
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @jdonszelmann. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
cc @yaahc |
Contributor
Author
|
To make sure the asserts are not expensive. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 12, 2026
resolve: Make sure visibilities of import declarations make sense
rustbot
added
the
S-waiting-on-perf
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (89a90f3): comparison URL. Overall result: no relevant changes - no action neededBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. @bors rollup=never Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 1.5%, secondary -6.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.6%, secondary 11.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 491.114s -> 490.825s (-0.06%) |
rustbot
removed
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
@rustbot reroll |
This comment has been minimized.
This comment has been minimized.
mu001999
reviewed
Apr 19, 2026
That they are all ordered inside the module and not more private than the module itself The `import_decl_vis` logic is reused when reporting `ambiguous_import_visibilities` lint Some asserts are hardened Some relevant tests are added
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
Rebased and updated. |
Member
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
…uwer Rollup of 11 pull requests Successful merges: - #154654 (Move `std::io::ErrorKind` to `core::io`) - #145270 (Fix an ICE observed with an explicit tail-call in a default trait method) - #154895 (borrowck: Apply `user_arg_index` nomenclature more broadly) - #155213 (resolve: Make sure visibilities of import declarations make sense) - #155346 (`single_use_lifetimes`: respect `anonymous_lifetime_in_impl_trait`) - #155517 (Add a test for Mach-O `#[link_section]` API inherited from LLVM) - #155549 (Remove some unnecessary lifetimes.) - #154248 (resolve : mark repr_simd as internal) - #154772 (slightly optimize the `non-camel-case-types` lint) - #155541 (Add `#[rust_analyzer::prefer_underscore_import]` to the traits in `rustc_type_ir::inherent`) - #155544 (bootstrap: Make "detected modifications" for download-rustc less verbose)
rust-timer
added a commit
that referenced
this pull request
Apr 20, 2026
Rollup merge of #155213 - petrochenkov:importvis, r=mu001999 resolve: Make sure visibilities of import declarations make sense That they are all ordered inside the module and not more private than the module itself. The `import_decl_vis` logic is also reused when reporting `ambiguous_import_visibilities` lint. Some asserts are hardened. Some relevant tests are added. Extracted from #154149.
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Apr 21, 2026
…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#154654 (Move `std::io::ErrorKind` to `core::io`) - rust-lang/rust#145270 (Fix an ICE observed with an explicit tail-call in a default trait method) - rust-lang/rust#154895 (borrowck: Apply `user_arg_index` nomenclature more broadly) - rust-lang/rust#155213 (resolve: Make sure visibilities of import declarations make sense) - rust-lang/rust#155346 (`single_use_lifetimes`: respect `anonymous_lifetime_in_impl_trait`) - rust-lang/rust#155517 (Add a test for Mach-O `#[link_section]` API inherited from LLVM) - rust-lang/rust#155549 (Remove some unnecessary lifetimes.) - rust-lang/rust#154248 (resolve : mark repr_simd as internal) - rust-lang/rust#154772 (slightly optimize the `non-camel-case-types` lint) - rust-lang/rust#155541 (Add `#[rust_analyzer::prefer_underscore_import]` to the traits in `rustc_type_ir::inherent`) - rust-lang/rust#155544 (bootstrap: Make "detected modifications" for download-rustc less verbose)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
That they are all ordered inside the module and not more private than the module itself.
The
import_decl_vislogic is also reused when reportingambiguous_import_visibilitieslint.Some asserts are hardened.
Some relevant tests are added.
Extracted from #154149.